Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Text extraction not working with one glyph to char sequence #1620

Merged
merged 1 commit into from
Feb 10, 2023
Merged

BUG: Text extraction not working with one glyph to char sequence #1620

merged 1 commit into from
Feb 10, 2023

Conversation

pubpub-zz
Copy link
Collaborator

fixes #1619

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
Can you rerun the check. My user rights seem to deny me to rerun actions.

@MartinThoma MartinThoma changed the title BUG : Text extaction not working with one gliph to char sequence BUG : Text extaction not working with one glyph to char sequence Feb 9, 2023
@MartinThoma
Copy link
Member

I re-ran the failed ones :-)

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 91.91% // Head: 91.92% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fe40441) compared to base (1b54821).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files          33       33           
  Lines        6372     6374    +2     
  Branches     1271     1272    +1     
=======================================
+ Hits         5857     5859    +2     
  Misses        327      327           
  Partials      188      188
Impacted Files Coverage Δ
pypdf/_page.py 90.53% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz pubpub-zz changed the title BUG : Text extaction not working with one glyph to char sequence BUG : Text extraction not working with one glyph to char sequence Feb 9, 2023
@MartinThoma MartinThoma merged commit f5ac79b into py-pdf:main Feb 10, 2023
@MartinThoma MartinThoma changed the title BUG : Text extraction not working with one glyph to char sequence BUG: Text extraction not working with one glyph to char sequence Feb 10, 2023
@MartinThoma MartinThoma added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF workflow-text-extraction From a users perspective, text extraction is the affected feature/workflow labels Feb 10, 2023
MartinThoma added a commit that referenced this pull request Feb 12, 2023
@MartinThoma
REL: 3.4.1
4e276b2 
Bug Fixes (BUG):
-  Switch from trimbox to cropbox when merging pages (#1622)
-  Text extraction not working with one glyph to char sequence (#1620)

Robustness (ROB):
-  Fix 2 cases of "object has no attribute \'indirect_reference\'" (#1616)

Testing (TST):
-  Add multiple retry on get_url for external PDF downloads (#1626)

[Full Changelog](3.4.0...3.4.1)
@pubpub-zz pubpub-zz deleted the old_habibi branch June 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF workflow-text-extraction From a users perspective, text extraction is the affected feature/workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text_extraction invalid for habibi.pdf
2 participants
@pubpub-zz @MartinThoma